Handling Empty Enums and Duplicate Enum Entries onLoad#275
Open
Corbin wants to merge 1 commit intoReClassNET:masterfrom
Open
Handling Empty Enums and Duplicate Enum Entries onLoad#275Corbin wants to merge 1 commit intoReClassNET:masterfrom
Corbin wants to merge 1 commit intoReClassNET:masterfrom
Conversation
…ues) the original code attempted to add every parsed enum to the project without checking if it contained any values. It also did have handling for the possibility of duplicate enum item names within the same enum which could also cause crashes.
sharmaniraj009
approved these changes
Feb 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the original code attempted to add every parsed enum to the project without checking if it contained any values. It also did have handling for the possibility of duplicate enum item names within the same enum on load which could also cause crashes.
Duplicates:
Adding a duplicate key to a Dictionary throws an argumentexception, leading to a crash. The code change checks for the existence of a key before adding it. If a duplicate key is found, the value is updated.
Empty Enums
Before adding an enum to the project, the code change checks if the values dictionary associated with the enum is empty. If it is, the enum is not added to the project. This prevents the creation of empty EnumDescription objects, which would lead to errors.